From: Miri Korenblit Date: Tue, 22 Mar 2022 15:39:43 +0000 (+0200) Subject: iwlwifi: mvm: Don't fail if PPAG isn't supported X-Git-Tag: v5.18-rc1~136^2~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b20bdd9cc9740ac1f2138adab25ddd51245c67be;p=thirdparty%2Fkernel%2Flinux.git iwlwifi: mvm: Don't fail if PPAG isn't supported When we're copying the PPAG table into the cmd structure we're failing if the table doesn't exist in ACPI or is invalid, or if the FW doesn't support PPAG setting etc. This is wrong because those are valid scenarios. Fix this by not failing in those cases. Fixes: e8e10a37c51c ("iwlwifi: acpi: move ppag code from mvm to fw/acpi") Tested-by: Oliver Hartkopp Signed-off-by: Miri Korenblit Signed-off-by: Luca Coelho Acked-by: Kalle Valo Link: https://lore.kernel.org/r/iwlwifi.20220322173828.fa47f369b717.I6a9c65149c2c3c11337f3a802dff22f514a3a436@changeid Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index 4632d3ad1a2bf..e842816134f11 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -1015,8 +1015,9 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm) int ret, cmd_size; ret = iwl_read_ppag_table(&mvm->fwrt, &cmd, &cmd_size); + /* Not supporting PPAG table is a valid scenario */ if(ret < 0) - return ret; + return 0; IWL_DEBUG_RADIO(mvm, "Sending PER_PLATFORM_ANT_GAIN_CMD\n"); ret = iwl_mvm_send_cmd_pdu(mvm, WIDE_ID(PHY_OPS_GROUP,