From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 10 Nov 2022 07:38:01 +0000 (+0100)
Subject: rtsp: only store first_host once
X-Git-Tag: curl-7_87_0~177
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b25e4be79f8ff8ebd061672da6680a8ebb37350a;p=thirdparty%2Fcurl.git

rtsp: only store first_host once

Suggested-by: Erik Janssen
URL: https://github.com/curl/curl/pull/9870#issuecomment-1309499744
Closes #9882
---

diff --git a/lib/rtsp.c b/lib/rtsp.c
index e32756fd87..b071458beb 100644
--- a/lib/rtsp.c
+++ b/lib/rtsp.c
@@ -270,15 +270,14 @@ static CURLcode rtsp_do(struct Curl_easy *data, bool *done)
   /* Setup the first_* fields to allow auth details get sent
      to this origin */
 
-  /* Free to avoid leaking memory on multiple requests */
-  free(data->state.first_host);
-
-  data->state.first_host = strdup(conn->host.name);
-  if(!data->state.first_host)
-    return CURLE_OUT_OF_MEMORY;
+  if(!data->state.first_host) {
+    data->state.first_host = strdup(conn->host.name);
+    if(!data->state.first_host)
+      return CURLE_OUT_OF_MEMORY;
 
-  data->state.first_remote_port = conn->remote_port;
-  data->state.first_remote_protocol = conn->handler->protocol;
+    data->state.first_remote_port = conn->remote_port;
+    data->state.first_remote_protocol = conn->handler->protocol;
+  }
 
   /* Setup the 'p_request' pointer to the proper p_request string
    * Since all RTSP requests are included here, there is no need to