From: Andres Freund Date: Mon, 8 Jun 2020 22:25:49 +0000 (-0700) Subject: spinlock emulation: Fix bug when more than INT_MAX spinlocks are initialized. X-Git-Tag: REL_10_14~59 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b295f666b7f0d613cf3c9fef211408a2ac4ed1f6;p=thirdparty%2Fpostgresql.git spinlock emulation: Fix bug when more than INT_MAX spinlocks are initialized. Once the counter goes negative we ended up with spinlocks that errored out on first use (due to check in tas_sema). Author: Andres Freund Reviewed-By: Robert Haas Discussion: https://postgr.es/m/20200606023103.avzrctgv7476xj7i@alap3.anarazel.de Backpatch: 9.5- --- diff --git a/src/backend/storage/lmgr/spin.c b/src/backend/storage/lmgr/spin.c index 2c16938f5a9..b8e6ef5a115 100644 --- a/src/backend/storage/lmgr/spin.c +++ b/src/backend/storage/lmgr/spin.c @@ -106,7 +106,7 @@ SpinlockSemaInit(void) void s_init_lock_sema(volatile slock_t *lock, bool nested) { - static int counter = 0; + static uint32 counter = 0; *lock = ((++counter) % NUM_SPINLOCK_SEMAPHORES) + 1; }