From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Thu, 22 Jun 2023 08:53:09 +0000 (+0100)
Subject: Always use revision number 1 when looking for status updates on the DACP remote contr... 
X-Git-Tag: 4.3~1^2~41
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b29e92b8cd273fa16699c1bb6750dfbda186bfda;p=thirdparty%2Fshairport-sync.git

Always use revision number 1 when looking for status updates on the DACP remote control port. This is ia hacky change to try out a (good) suggestion in Issue #1658.
---

diff --git a/dacp.c b/dacp.c
index 50cf0e17..c7adac58 100644
--- a/dacp.c
+++ b/dacp.c
@@ -411,6 +411,7 @@ void set_dacp_server_information(rtsp_conn_info *conn) {
     debug(2, "set_dacp_server_information set IP to \"%s\" and DACP id to \"%s\".",
           dacp_server.ip_string, dacp_server.dacp_id);
 
+/*
     // If the client is forked-daapd, then we always use revision number 1
     // because otherwise the return read will hang in a "long poll" if there
     // are no changes.
@@ -424,6 +425,10 @@ void set_dacp_server_information(rtsp_conn_info *conn) {
         dacp_server.always_use_revision_number_1 = 1;
       }
     }
+*/
+
+    // always use revision number 1
+    dacp_server.always_use_revision_number_1 = 1;
 
     metadata_hub_modify_prolog();
     int ch = metadata_store.dacp_server_active != dacp_server.scan_enable;