From: Chen Qun Date: Mon, 16 Nov 2020 02:48:09 +0000 (+0800) Subject: ppc: Add a missing break for PPC6xx_INPUT_TBEN X-Git-Tag: v6.0.0-rc0~182^2~21 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b2bd5b20fd1854cdbfee87553855163081a6c531;p=thirdparty%2Fqemu.git ppc: Add a missing break for PPC6xx_INPUT_TBEN When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] 118 | if (level) { | ^ hw/ppc/ppc.c:123:9: note: here 123 | case PPC6xx_INPUT_INT: | ^~~~ According to the discussion, a break statement needs to be added here. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Thomas Huth Acked-by: David Gibson Message-Id: <20201116024810.2415819-7-kuhn.chenqun@huawei.com> Signed-off-by: David Gibson --- diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640f..1b982720767 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) } else { cpu_ppc_tb_stop(env); } + break; case PPC6xx_INPUT_INT: /* Level sensitive - active high */ LOG_IRQ("%s: set the external IRQ state to %d\n",