From: drh <drh@noemail.net>
Date: Tue, 7 Apr 2020 00:54:09 +0000 (+0000)
Subject: Remove dead code that was added during initial development of RENAME COLUMN
X-Git-Tag: version-3.32.0~84
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b3120fdf5be0ae665448f0e3d694a53f12a635bc;p=thirdparty%2Fsqlite.git

Remove dead code that was added during initial development of RENAME COLUMN
but never actually served a purpose.

FossilOrigin-Name: c95c4cda4640f05d61b13b4e60494dec07d4483734fc41ffcce73fb5163cbb0d
---

diff --git a/manifest b/manifest
index fa97f79655..9f7663d7fa 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Performance\simprovement\sin\ssqlite3ResolveExprNameList().
-D 2020-04-06T20:35:52.507
+C Remove\sdead\scode\sthat\swas\sadded\sduring\sinitial\sdevelopment\sof\sRENAME\sCOLUMN\nbut\snever\sactually\sserved\sa\spurpose.
+D 2020-04-07T00:54:09.100
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -483,7 +483,7 @@ F src/date.c b29b349d277e3d579dcc295b24c0a2caed83fd8f090a9f7cbe6070c0fd662384
 F src/dbpage.c 8a01e865bf8bc6d7b1844b4314443a6436c07c3efe1d488ed89e81719047833a
 F src/dbstat.c 793deaf88a0904f88285d93d6713c636d55ede0ffd9f08d10f4ea825531d367f
 F src/delete.c 11000121c4281c0bce4e41db29addfaea0038eaa127ece02557c9207bc3e541d
-F src/expr.c 29b4aedca855c6ef86786db894c6961605a9a1e70af23617db2976aea6c2c122
+F src/expr.c daac9c5a0a47a9b8115ee24ef2d0e8be5e74e1d932fc72677b2c239380c2e0e1
 F src/fault.c 460f3e55994363812d9d60844b2a6de88826e007
 F src/fkey.c 4b575423b0a5d4898b1a7868ce985cf1a8ad91c741c9abbb108ff02536d20f41
 F src/func.c f3dcdc0e95509864767c1f0991b19360f969e44177f4e058fd51da9a6154f47e
@@ -1860,7 +1860,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 1e4b6a93987cdfbf829e2ff35ef417c290625f2894ad11949e301af518f1fb44
-R 5912d7879df9e5ed94612a377e764286
+P 7e170e67f24c7cdef7e7ceac4e0b81a75382618e4abe9e604f3d7f6db9dc6396
+R 96b603cf5952b339ffd4e6938833516a
 U drh
-Z 3f671a69f5df518d39221297552a02ec
+Z 5f8493cb155b275011c6713c52ec3f87
diff --git a/manifest.uuid b/manifest.uuid
index 15622b5a78..1048e21996 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-7e170e67f24c7cdef7e7ceac4e0b81a75382618e4abe9e604f3d7f6db9dc6396
\ No newline at end of file
+c95c4cda4640f05d61b13b4e60494dec07d4483734fc41ffcce73fb5163cbb0d
\ No newline at end of file
diff --git a/src/expr.c b/src/expr.c
index b9b3b9ee6f..0629f508aa 100644
--- a/src/expr.c
+++ b/src/expr.c
@@ -3844,10 +3844,6 @@ expr_code_doover:
           static const char zAff[] = "B\000C\000D\000E";
           assert( SQLITE_AFF_BLOB=='A' );
           assert( SQLITE_AFF_TEXT=='B' );
-          if( iReg!=target ){
-            sqlite3VdbeAddOp2(v, OP_SCopy, iReg, target);
-            iReg = target;
-          }
           sqlite3VdbeAddOp4(v, OP_Affinity, iReg, 1, 0,
                             &zAff[(aff-'B')*2], P4_STATIC);
         }