From: Siva Durga Prasad Paladugu Date: Sat, 16 Mar 2019 12:21:23 +0000 (+0530) Subject: net: phy: micrel_ksz90x1: switch to use ofnode apis X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b351de58a9fe146ae890655da06e8f22debde397;p=thirdparty%2Fu-boot.git net: phy: micrel_ksz90x1: switch to use ofnode apis phydev->node is phy node, phydev->dev->node is controller and that current code is likely reading the properties from controller node and not from phy. So, Use PHY API phy_get_ofnode() helper to get PHY DT node and use ofnode_read_u32_default() to read properties in phy node. Signed-off-by: Siva Durga Prasad Paladugu Changes for v2: - Updated description Signed-off-by: Michal Simek --- diff --git a/drivers/net/phy/micrel_ksz90x1.c b/drivers/net/phy/micrel_ksz90x1.c index 3951535bf1f..355a7d8e97e 100644 --- a/drivers/net/phy/micrel_ksz90x1.c +++ b/drivers/net/phy/micrel_ksz90x1.c @@ -104,18 +104,22 @@ static const struct ksz90x1_reg_field ksz9031_clk_grp[] = { static int ksz90x1_of_config_group(struct phy_device *phydev, struct ksz90x1_ofcfg *ofcfg) { - struct udevice *dev = phydev->dev; struct phy_driver *drv = phydev->drv; const int ps_to_regval = 60; int val[4]; int i, changed = 0, offset, max; u16 regval = 0; + ofnode node; if (!drv || !drv->writeext) return -EOPNOTSUPP; + node = phy_get_ofnode(phydev); + if (!ofnode_valid(node)) + return -EINVAL; + for (i = 0; i < ofcfg->grpsz; i++) { - val[i] = dev_read_u32_default(dev, ofcfg->grp[i].name, ~0); + val[i] = ofnode_read_u32_default(node, ofcfg->grp[i].name, ~0); offset = ofcfg->grp[i].off; if (val[i] == -1) { /* Default register value for KSZ9021 */