From: Aki Tuomi <aki.tuomi@dovecot.fi>
Date: Fri, 31 Mar 2017 07:57:14 +0000 (+0300)
Subject: lib-imap-client: Make authentication failures more consistent
X-Git-Tag: 2.2.29.rc1~18
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b376929cd20b42d60db8cea3b9ad57722df9c678;p=thirdparty%2Fdovecot%2Fcore.git

lib-imap-client: Make authentication failures more consistent

This way they always say the same prefix, which is easier to
spot.
---

diff --git a/src/lib-imap-client/imapc-connection.c b/src/lib-imap-client/imapc-connection.c
index 2423618ebb..be6b95260d 100644
--- a/src/lib-imap-client/imapc-connection.c
+++ b/src/lib-imap-client/imapc-connection.c
@@ -160,11 +160,14 @@ imapc_auth_ok(struct imapc_connection *conn)
 }
 
 static void
-imapc_auth_failed(struct imapc_connection *conn, const struct imapc_command_reply *reply,
+imapc_auth_failed(struct imapc_connection *conn, const struct imapc_command_reply *_reply,
 		  const char *error)
 {
-	i_error("imapc(%s): Authentication failed: %s", conn->name, error);
-	imapc_login_callback(conn, reply);
+	struct imapc_command_reply reply = *_reply;
+	reply.text_without_resp = reply.text_full =
+		t_strdup_printf("Authentication failed: %s", error);
+	i_error("imapc(%s): %s", conn->name, reply.text_full);
+	imapc_login_callback(conn, &reply);
 
 	if (conn->client->state_change_callback == NULL)
 		return;