From: Willy Tarreau <w@1wt.eu>
Date: Sat, 16 Oct 2021 12:41:09 +0000 (+0200)
Subject: BUG/MINOR: sample: fix backend direction flags consecutive to last fix
X-Git-Tag: v2.5-dev10~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b39e47a52b19e7b62727393f9b8e8bd36330b550;p=thirdparty%2Fhaproxy.git

BUG/MINOR: sample: fix backend direction flags consecutive to last fix

Commit 7a06ffb85 ("BUG/MEDIUM: sample: Cumulate frontend and backend
sample validity flags") introduced a typo confusing the request and
the response direction when checking for validity of a rule applied
to a backend. This was reported by Coverity in issue #1417.

This needs to be backported where the patch above is backported.
---

diff --git a/src/http_htx.c b/src/http_htx.c
index 484b424862..bfdcaef863 100644
--- a/src/http_htx.c
+++ b/src/http_htx.c
@@ -1410,7 +1410,7 @@ struct http_reply *http_parse_http_reply(const char **args, int *orig_arg, struc
 		if (px->cap & PR_CAP_FE)
 			cap |= ((px->conf.args.ctx == ARGC_HRQ) ? SMP_VAL_FE_HRQ_HDR : SMP_VAL_FE_HRS_HDR);
 		if (px->cap & PR_CAP_BE)
-			cap |= ((px->conf.args.ctx == ARGC_HRQ) ? SMP_VAL_BE_HRS_HDR : SMP_VAL_BE_HRS_HDR);
+			cap |= ((px->conf.args.ctx == ARGC_HRQ) ? SMP_VAL_BE_HRQ_HDR : SMP_VAL_BE_HRS_HDR);
 	}
 
 	cur_arg = *orig_arg;