From: Marc Poulhiès <poulhies@adacore.com>
Date: Tue, 20 Dec 2022 14:54:00 +0000 (+0100)
Subject: ada: Fix storage model handling for dereference as lvalue and renamings
X-Git-Tag: basepoints/gcc-15~8755
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b3c206bf46a36bac12cbd863be092625593ad0bb;p=thirdparty%2Fgcc.git

ada: Fix storage model handling for dereference as lvalue and renamings

Don't require storage access for explicit dereferences used as
lvalue (e.g. Some_Access.all'Address) or for renamings.

gcc/ada/

	* gcc-interface/trans.cc (get_storage_model_access): Don't require
	storage model access for dereference used as lvalue or renamings.
---

diff --git a/gcc/ada/gcc-interface/trans.cc b/gcc/ada/gcc-interface/trans.cc
index 13f438c424b9..f4a5db002f44 100644
--- a/gcc/ada/gcc-interface/trans.cc
+++ b/gcc/ada/gcc-interface/trans.cc
@@ -4398,14 +4398,32 @@ static void
 get_storage_model_access (Node_Id gnat_node, Entity_Id *gnat_smo)
 {
   const Node_Id gnat_parent = Parent (gnat_node);
+  *gnat_smo = Empty;
 
-  /* If we are the prefix of the parent, then the access is above us.  */
-  if (node_is_component (gnat_parent) && Prefix (gnat_parent) == gnat_node)
+  switch (Nkind (gnat_parent))
     {
-      *gnat_smo = Empty;
+    case N_Attribute_Reference:
+      /* If the parent is an attribute reference that requires an lvalue and
+         gnat_node is the Prefix (i.e. not a parameter), we do not need to
+         actually access any storage. */
+      if (lvalue_required_for_attribute_p (gnat_parent)
+          && Prefix (gnat_parent) == gnat_node)
+        return;
+      break;
+
+    case N_Object_Renaming_Declaration:
+      /* Nothing to do for the identifier in an object renaming declaration,
+         the renaming itself does not need storage model access. */
       return;
+
+    default:
+      break;
     }
 
+  /* If we are the prefix of the parent, then the access is above us.  */
+  if (node_is_component (gnat_parent) && Prefix (gnat_parent) == gnat_node)
+    return;
+
   /* Now strip any type conversion from GNAT_NODE.  */
   if (Nkind (gnat_node) == N_Type_Conversion
       || Nkind (gnat_node) == N_Unchecked_Type_Conversion)