From: Bartlomiej Zolnierkiewicz Date: Tue, 9 Oct 2018 14:45:20 +0000 (+0200) Subject: ata: remove redundant 'default n' from Kconfig X-Git-Tag: v4.20-rc1~190^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b3cd92db6ecde0a1c3651771a23f45b708533de4;p=thirdparty%2Fkernel%2Flinux.git ata: remove redundant 'default n' from Kconfig 'default n' is the default value for any bool or tristate Kconfig setting so there is no need to write it explicitly. Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO is not set' for visible symbols") the Kconfig behavior is the same regardless of 'default n' being present or not: ... One side effect of (and the main motivation for) this change is making the following two definitions behave exactly the same: config FOO bool config FOO bool default n With this change, neither of these will generate a '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). That might make it clearer to people that a bare 'default n' is redundant. ... Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Jens Axboe --- diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 99698d7fe585a..4ca7a6b4eaaef 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -33,7 +33,6 @@ if ATA config ATA_NONSTANDARD bool - default n config ATA_VERBOSE_ERROR bool "Verbose ATA error reporting" @@ -62,7 +61,6 @@ config ATA_ACPI config SATA_ZPODD bool "SATA Zero Power Optical Disc Drive (ZPODD) support" depends on ATA_ACPI && PM - default n help This option adds support for SATA Zero Power Optical Disc Drive (ZPODD). It requires both the ODD and the platform