From: Oliver Hartkopp Date: Tue, 12 Jan 2021 09:16:43 +0000 (+0100) Subject: can: isotp: isotp_getname(): fix kernel information leak X-Git-Tag: v5.11-rc4~25^2~12^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b42b3a2744b3e8f427de79896720c72823af91ad;p=thirdparty%2Fkernel%2Flinux.git can: isotp: isotp_getname(): fix kernel information leak Initialize the sockaddr_can structure to prevent a data leak to user space. Suggested-by: Cong Wang Reported-by: syzbot+057884e2f453e8afebc8@syzkaller.appspotmail.com Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol") Signed-off-by: Oliver Hartkopp Link: https://lore.kernel.org/r/20210112091643.11789-1-socketcan@hartkopp.net Signed-off-by: Marc Kleine-Budde --- diff --git a/net/can/isotp.c b/net/can/isotp.c index 7839c3b9e5bea..3ef7f78e553bc 100644 --- a/net/can/isotp.c +++ b/net/can/isotp.c @@ -1155,6 +1155,7 @@ static int isotp_getname(struct socket *sock, struct sockaddr *uaddr, int peer) if (peer) return -EOPNOTSUPP; + memset(addr, 0, sizeof(*addr)); addr->can_family = AF_CAN; addr->can_ifindex = so->ifindex; addr->can_addr.tp.rx_id = so->rxid;