From: Bob Wilson <bob.wilson@acm.org>
Date: Thu, 18 Sep 2008 00:37:47 +0000 (+0000)
Subject:         * elf32-xtensa.c (elf_xtensa_check_relocs): Check for negative refcount.
X-Git-Tag: reverse-20080930-branchpoint~100
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b45329f94ab8c22f8475b1c47e2d1e255cadf422;p=thirdparty%2Fbinutils-gdb.git

    * elf32-xtensa.c (elf_xtensa_check_relocs): Check for negative refcount.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 97c46de6e47..4a1769d1957 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2008-09-17  Bob Wilson  <bob.wilson@acm.org>
+
+	* elf32-xtensa.c (elf_xtensa_check_relocs): Check for negative refcount.
+
 2008-09-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	PR 6893 - Do not consider FDEs for discarded sections as invalid.
diff --git a/bfd/elf32-xtensa.c b/bfd/elf32-xtensa.c
index 3463efa8c34..dadf42bc42b 100644
--- a/bfd/elf32-xtensa.c
+++ b/bfd/elf32-xtensa.c
@@ -1087,8 +1087,13 @@ elf_xtensa_check_relocs (bfd *abfd,
 	{
 	  if (is_plt)
 	    {
-	      h->plt.refcount += 1;
-	      h->needs_plt = 1;
+	      if (h->plt.refcount <= 0)
+		{
+		  h->needs_plt = 1;
+		  h->plt.refcount = 1;
+		}
+	      else
+		h->plt.refcount += 1;
 
 	      /* Keep track of the total PLT relocation count even if we
 		 don't yet know whether the dynamic sections will be
@@ -1102,7 +1107,12 @@ elf_xtensa_check_relocs (bfd *abfd,
 		}
 	    }
 	  else if (is_got)
-	    h->got.refcount += 1;
+	    {
+	      if (h->got.refcount <= 0)
+		h->got.refcount = 1;
+	      else
+		h->got.refcount += 1;
+	    }
 
 	  if (is_tlsfunc)
 	    eh->tlsfunc_refcount += 1;