From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 31 Mar 2022 13:31:32 +0000 (+0100)
Subject: media: i2c: dw9714: Return zero in remove callback
X-Git-Tag: v5.19-rc1~179^2~236
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b4657e00115d0c87970a2386338b70fa95ef4ac6;p=thirdparty%2Fkernel%2Flinux.git

media: i2c: dw9714: Return zero in remove callback

The only effect of returning an error code in an i2c remove callback is
that the i2c core emits a generic warning and still removes the device.

So even if disabling the regulator fails it's sensible to further cleanup
and then return zero to only emit a single error message.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---

diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c
index 8c5797ba57d41..206d74338b9c9 100644
--- a/drivers/media/i2c/dw9714.c
+++ b/drivers/media/i2c/dw9714.c
@@ -202,7 +202,6 @@ static int dw9714_remove(struct i2c_client *client)
 		if (ret) {
 			dev_err(&client->dev,
 				"Failed to disable vcc: %d\n", ret);
-			return ret;
 		}
 	}
 	pm_runtime_set_suspended(&client->dev);