From: Uwe Kleine-König Date: Sun, 12 Mar 2023 16:14:45 +0000 (+0100) Subject: clk: xilinx: Drop if block with always false condition X-Git-Tag: v6.4-rc1~74^2~3^4~23 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b46d59cb18321705d7fe8cf84c20e01553116418;p=thirdparty%2Fkernel%2Flinux.git clk: xilinx: Drop if block with always false condition xvcu_remove() is only called for a device after after xvcu_probe() completed successfully. In that case dev_set_drvdata() was called for that device with a non-NULL parameter, so platform_get_drvdata() won't return NULL and the if condition is never true. Drop the if, preparing a conversion to make platform driver's remove callback return void. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230312161512.2715500-4-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/xilinx/xlnx_vcu.c b/drivers/clk/xilinx/xlnx_vcu.c index d66b1315114e6..54b44debfd3e8 100644 --- a/drivers/clk/xilinx/xlnx_vcu.c +++ b/drivers/clk/xilinx/xlnx_vcu.c @@ -707,8 +707,6 @@ static int xvcu_remove(struct platform_device *pdev) struct xvcu_device *xvcu; xvcu = platform_get_drvdata(pdev); - if (!xvcu) - return -ENODEV; xvcu_unregister_clock_provider(xvcu);