From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Thu, 23 Nov 2023 12:55:13 +0000 (+0100)
Subject: clarify that the mssql password is not a secret
X-Git-Tag: dnsdist-1.9.0-alpha4~19^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b47c41d184a7f3f165b0fce5f64caa985b1d1ba5;p=thirdparty%2Fpdns.git

clarify that the mssql password is not a secret
---

diff --git a/.github/workflows/build-and-test-all.yml b/.github/workflows/build-and-test-all.yml
index 5a02ba2f51..4290cda1ed 100644
--- a/.github/workflows/build-and-test-all.yml
+++ b/.github/workflows/build-and-test-all.yml
@@ -359,7 +359,7 @@ jobs:
             image: mcr.microsoft.com/mssql/server:2017-GA-ubuntu
             env:
               ACCEPT_EULA: Y
-              SA_PASSWORD: 'SAsa12%%'
+              SA_PASSWORD: 'SAsa12%%-not-a-secret-password'
             ports:
               - 1433:1433
           - backend: ldap
diff --git a/tasks.py b/tasks.py
index 2d6a987ee0..258bb884b4 100644
--- a/tasks.py
+++ b/tasks.py
@@ -739,7 +739,7 @@ backend_regress_tests = dict(
     geoip_mmdb = ['geoip'],
 )
 
-godbc_mssql_credentials = {"username": "sa", "password": "SAsa12%%"}
+godbc_mssql_credentials = {"username": "sa", "password": "SAsa12%%-not-a-secret-password"}
 
 godbc_config = f'''
 [pdns-mssql-docker]