From: Li Zetao Date: Thu, 22 Aug 2024 13:39:03 +0000 (+0800) Subject: net: caif: use max() to simplify the code X-Git-Tag: v6.12-rc1~232^2~184^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b4985aa8e312fd40fbbce0fe44ce677368fdee43;p=thirdparty%2Fkernel%2Flinux.git net: caif: use max() to simplify the code When processing the tail append of sk buffer, the final length needs to be determined based on expectlen and addlen. Using max() here can increase the readability of the code. Signed-off-by: Li Zetao Reviewed-by: Simon Horman Link: https://patch.msgid.link/20240822133908.1042240-4-lizetao1@huawei.com Signed-off-by: Jakub Kicinski --- diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c index 2ae8cfa3df884..96236d21b18e5 100644 --- a/net/caif/cfpkt_skbuff.c +++ b/net/caif/cfpkt_skbuff.c @@ -298,10 +298,8 @@ struct cfpkt *cfpkt_append(struct cfpkt *dstpkt, if (unlikely(is_erronous(dstpkt) || is_erronous(addpkt))) { return dstpkt; } - if (expectlen > addlen) - neededtailspace = expectlen; - else - neededtailspace = addlen; + + neededtailspace = max(expectlen, addlen); if (dst->tail + neededtailspace > dst->end) { /* Create a dumplicate of 'dst' with more tail space */