From: Daniel Walter <d.walter@0x90.at>
Date: Thu, 23 Aug 2012 01:33:16 +0000 (+1200)
Subject: Bug 3605: memory leak in Negotiate authentication
X-Git-Tag: sourceformat-review-1~64^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b4eca36b04c9cf6468b6103600925704960fe19e;p=thirdparty%2Fsquid.git

Bug 3605: memory leak in Negotiate authentication
---

diff --git a/src/auth/negotiate/UserRequest.cc b/src/auth/negotiate/UserRequest.cc
index 59c43d7c0a..9acc2616f5 100644
--- a/src/auth/negotiate/UserRequest.cc
+++ b/src/auth/negotiate/UserRequest.cc
@@ -368,7 +368,10 @@ Auth::Negotiate::UserRequest::HandleReply(void *data, void *lastserver, char *re
         fatalf("authenticateNegotiateHandleReply: *** Unsupported helper response ***, '%s'\n", reply);
     }
 
-    lm_request->request = NULL;
+    if (lm_request->request) {
+        HTTPMSGUNLOCK(lm_request->request);
+        lm_request->request = NULL;
+    }
     r->handler(r->data);
     delete r;
 }