From: Willy Tarreau <w@1wt.eu>
Date: Mon, 16 Apr 2012 12:51:55 +0000 (+0200)
Subject: CLEANUP: http: message parser must ignore HTTP_MSG_ERROR
X-Git-Tag: v1.5-dev9~99
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b56928a74cfb8288e1d2246b9350e39d491a3236;p=thirdparty%2Fhaproxy.git

CLEANUP: http: message parser must ignore HTTP_MSG_ERROR

The issue only happens when DEBUG_FULL is enabled, which causes
http_msg_analyzer() to complain if it's called twice with an invalid
message, for instance because of two consecutive ACLs using req_proto_http.

The code is commented out when DEBUG_FULL is disabled, so this is not a bug,
just an annoyance for the developer.
---

diff --git a/src/proto_http.c b/src/proto_http.c
index ae300473eb..22623c058a 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -1569,6 +1569,11 @@ void http_msg_analyzer(struct buffer *buf, struct http_msg *msg, struct hdr_idx
 		msg->sol = buf->data + msg->som;
 		msg->msg_state = HTTP_MSG_BODY;
 		return;
+
+	case HTTP_MSG_ERROR:
+		/* this may only happen if we call http_msg_analyser() twice with an error */
+		break;
+
 #ifdef DEBUG_FULL
 	default:
 		fprintf(stderr, "FIXME !!!! impossible state at %s:%d = %d\n", __FILE__, __LINE__, state);