From: Phil Carmody <phil@dovecot.fi>
Date: Tue, 19 Jun 2018 12:30:36 +0000 (+0300)
Subject: m4/dovecot.m4: rename valgrind output file to hide it from certain tests
X-Git-Tag: 2.3.5~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b5a86f084c1670bb51e73a032b86ef5f95ace687;p=thirdparty%2Fdovecot%2Fcore.git

m4/dovecot.m4: rename valgrind output file to hide it from certain tests

Some lib-http tests use readdir() to create test cases, and sometimes
object to the contents of test.out.$$. However, as lib-http is also
sensitive to certain characters in the filenames of the files it uses,
we can hide the valgrind output by chosing its filename to exclude it
from the lib_http tests. Non-initial '~' is not known to cause any issues
for either the shell or any known operating system, so is the safest of
lib-http's 'dodgy' characters to use as the separator.

Signed-off-by: Phil Carmody <phil@dovecot.fi>
---

diff --git a/m4/dovecot.m4 b/m4/dovecot.m4
index 149105e9c6..980f6309b9 100644
--- a/m4/dovecot.m4
+++ b/m4/dovecot.m4
@@ -285,7 +285,7 @@ if test "\$NOVALGRIND" != ""; then
   \$[*]
   ret=\$?
 else
-  test_out="test.out.\$\$"
+  test_out="test.out~\$\$"
   trap "rm -f \$test_out" 0 1 2 3 15
   supp_path="\$top_srcdir/run-test-valgrind.supp"
   if test -r "\$supp_path"; then