From: robertc <>
Date: Tue, 21 Oct 2003 15:30:09 +0000 (+0000)
Subject: Add comment explaining cause of asserts in stmem.cc
X-Git-Tag: SQUID_3_0_PRE4~1177
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b631f31c0725703a8dd5607bc129fb4bd678225e;p=thirdparty%2Fsquid.git

Add comment explaining cause of asserts in stmem.cc
---

diff --git a/src/client_side.cc b/src/client_side.cc
index 8069e107c5..ae79b4f8ca 100644
--- a/src/client_side.cc
+++ b/src/client_side.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: client_side.cc,v 1.664 2003/10/21 09:22:59 robertc Exp $
+ * $Id: client_side.cc,v 1.665 2003/10/21 09:30:09 robertc Exp $
  *
  * DEBUG: section 33    Client-side Routines
  * AUTHOR: Duane Wessels
@@ -1082,7 +1082,11 @@ ClientSocketContext::buildRangeHeader(HttpReply * rep)
 #endif
     /* get rid of our range specs on error */
     if (range_err) {
-        /* XXX Why do we do this here, and not when parsing the request ? */
+        /* XXX We do this here because we need canonisation etc. However, this current
+         * code will lead to incorrect store offset requests - the store will have the 
+         * offset data, but we won't be requesting it.
+         * So, we can either re-request, or generate an error
+         */
         debug(33, 3) ("clientBuildRangeHeader: will not do ranges: %s.\n", range_err);
         delete http->request->range;
         http->request->range = NULL;