From: Volker Lendecke <vl@samba.org>
Date: Wed, 27 Nov 2024 15:40:03 +0000 (+0100)
Subject: libcli: Remove a special case
X-Git-Tag: tdb-1.4.13~419
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b65a4b9c90e43f2f9a8acfe0b4ed4e9cad5c489d;p=thirdparty%2Fsamba.git

libcli: Remove a special case

dom_sid_parse_endp does accept the lowercase "s" in "s-1-1-0".

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index c2a6ca26fc3..0796a52878f 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -230,13 +230,6 @@ static struct dom_sid *sddl_transition_decode_sid(TALLOC_CTX *mem_ctx, const cha
 		if (sid_str == NULL) {
 			return NULL;
 		}
-		if (sid_str[0] == 's') {
-			/*
-			 * In SDDL, but not in the dom_sid parsers, a
-			 * lowercase "s-1-1-0" is accepted.
-			 */
-			sid_str[0] = 'S';
-		}
 		sid = talloc(mem_ctx, struct dom_sid);
 		if (sid == NULL) {
 			TALLOC_FREE(sid_str);