From: TCY16 <tom@nlnetlabs.nl>
Date: Fri, 18 Nov 2022 10:30:11 +0000 (+0100)
Subject: remove superfluous variables
X-Git-Tag: release-1.18.0rc1~34
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b65ff768bc85799e1eb1cd195e37570f0aafd5ab;p=thirdparty%2Funbound.git

remove superfluous variables
---

diff --git a/daemon/worker.c b/daemon/worker.c
index a13bb9530..528943c6b 100644
--- a/daemon/worker.c
+++ b/daemon/worker.c
@@ -486,11 +486,9 @@ answer_norec_from_cache(struct worker* worker, struct query_info* qinfo,
 					return 0;
 			/* Attached the cached EDE (RFC8914) */
 			if (worker->env.cfg->ede) {
-				char* reason_bogus_str = msg->rep->reason_bogus_str;
-
 				edns_opt_list_append_ede(&edns->opt_list_out,
 					worker->scratchpad, msg->rep->reason_bogus,
-					reason_bogus_str);
+					msg->rep->reason_bogus_str);
 			}
 			error_encode(repinfo->c->buffer, LDNS_RCODE_SERVFAIL, 
 				&msg->qinfo, id, flags, edns);
@@ -664,11 +662,9 @@ answer_from_cache(struct worker* worker, struct query_info* qinfo,
 			goto bail_out;
 		/* Attached the cached EDE (RFC8914) */
 		if (worker->env.cfg->ede) {
-			char* reason_bogus_str = rep->reason_bogus_str;
-
 			edns_opt_list_append_ede(&edns->opt_list_out,
 					worker->scratchpad, rep->reason_bogus,
-					reason_bogus_str);
+					rep->reason_bogus_str);
 		}
 		error_encode(repinfo->c->buffer, LDNS_RCODE_SERVFAIL,
 			qinfo, id, flags, edns);