From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 31 Oct 2023 11:10:55 +0000 (+0100)
Subject: qga: Improve guest-exec-status error message
X-Git-Tag: v8.2.0-rc1~12^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b665165938d89c8e1f83f970d3722f507ce87acd;p=thirdparty%2Fqemu.git

qga: Improve guest-exec-status error message

When the PID passed to guest-exec-status does not exist, we report

    "Invalid parameter 'pid'"

Improve this to

    "PID 1234 does not exist"

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231031111059.3407803-4-armbru@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---

diff --git a/qga/commands.c b/qga/commands.c
index ce172edd2d0..88c1c99fe51 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -154,7 +154,7 @@ GuestExecStatus *qmp_guest_exec_status(int64_t pid, Error **errp)
 
     gei = guest_exec_info_find(pid);
     if (gei == NULL) {
-        error_setg(errp, QERR_INVALID_PARAMETER, "pid");
+        error_setg(errp, "PID " PRId64 " does not exist");
         return NULL;
     }