From: Phil Sutter <phil@nwl.cc>
Date: Wed, 19 Sep 2018 13:16:58 +0000 (+0200)
Subject: iptables-apply: Replace signal numbers by names
X-Git-Tag: v1.8.1~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b686594b976ddbfb1809ecfe016784bb53bbe9ac;p=thirdparty%2Fiptables.git

iptables-apply: Replace signal numbers by names

As covscan stated: "Trapping signals by number is not well defined.
Prefer signal names."

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
---

diff --git a/iptables/iptables-apply b/iptables/iptables-apply
index c7b12d07..819ca4a4 100755
--- a/iptables/iptables-apply
+++ b/iptables/iptables-apply
@@ -123,7 +123,8 @@ done
 umask 0700
 
 TMPFILE=$(tempfile -p iptap)
-trap "rm -f $TMPFILE" EXIT 1 2 3 4 5 6 7 8 10 11 12 13 14 15
+trap "rm -f $TMPFILE" EXIT HUP INT QUIT ILL TRAP ABRT BUS \
+		      FPE USR1 SEGV USR2 PIPE ALRM TERM
 
 if ! "$SAVE" >"$TMPFILE"; then
 	if ! grep -q ipt /proc/modules 2>/dev/null; then