From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Sat, 4 May 2024 01:07:26 +0000 (+1200)
Subject: domsid: be less alarmed by non-SID
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b6a80e68b7a26eccaaf822d7877b6870196c086d;p=thirdparty%2Fsamba.git

domsid: be less alarmed by non-SID

This has been causing log noise when something is trying to parse an
identifier using a sequence of parsers, to see if it is a SID, a DN,
an account name, etc.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c
index c898d87f64a..2cb755dcd42 100644
--- a/libcli/security/dom_sid.c
+++ b/libcli/security/dom_sid.c
@@ -163,7 +163,8 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
 	*sidout = (struct dom_sid) {};
 
 	if ((sidstr[0] != 'S' && sidstr[0] != 's') || sidstr[1] != '-') {
-		goto format_error;
+		DBG_INFO("'%s' is not a SID\n", sidstr);
+		return false;
 	}
 
 	/* Get the revision number. */