From: Daniel P. Berrangé <berrange@redhat.com>
Date: Mon, 28 Apr 2025 16:22:14 +0000 (+0100)
Subject: util: remove use hardcoded MODPROBE/RMMOD paths
X-Git-Tag: v11.4.0-rc1~122
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b6e50df68d227a0c107c09b4720714f248fd09dd;p=thirdparty%2Flibvirt.git

util: remove use hardcoded MODPROBE/RMMOD paths

Allow virCommand to find 'modprobe' & 'rmmod' in $PATH. These commands
are only used when running privileged in which case both 'bin' and
'sbin' dirs will be in $PATH, so virFindFileInPath will do the right
thing to find them.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/meson.build b/meson.build
index eb85f93e5d..e9d5f2bf0b 100644
--- a/meson.build
+++ b/meson.build
@@ -854,9 +854,7 @@ optional_test_programs = [
 ]
 
 optional_programs = [
-  'modprobe',
   'ovs-vsctl',
-  'rmmod',
   'tc',
 ] + optional_test_programs
 
diff --git a/src/util/virkmod.c b/src/util/virkmod.c
index 4c709f8659..111627f4b1 100644
--- a/src/util/virkmod.c
+++ b/src/util/virkmod.c
@@ -29,7 +29,7 @@ doModprobe(const char *opts, const char *module, char **outbuf, char **errbuf)
 {
     g_autoptr(virCommand) cmd = NULL;
 
-    cmd = virCommandNewArgList(MODPROBE, opts, NULL);
+    cmd = virCommandNewArgList("modprobe", opts, NULL);
     if (module)
         virCommandAddArg(cmd, module);
     if (outbuf)
@@ -48,7 +48,7 @@ doRmmod(const char *module, char **errbuf)
 {
     g_autoptr(virCommand) cmd = NULL;
 
-    cmd = virCommandNewArgList(RMMOD, module, NULL);
+    cmd = virCommandNewArgList("rmmod", module, NULL);
     virCommandSetErrorBuffer(cmd, errbuf);
 
     if (virCommandRun(cmd, NULL) < 0)
diff --git a/tests/virkmodtest.c b/tests/virkmodtest.c
index ec28ef1282..eb9a2aa740 100644
--- a/tests/virkmodtest.c
+++ b/tests/virkmodtest.c
@@ -63,7 +63,7 @@ testKModLoad(const void *args G_GNUC_UNUSED)
         return -1;
     }
 
-    if (checkOutput(&buf, MODPROBE " -b " MODNAME "\n") < 0)
+    if (checkOutput(&buf, "modprobe -b " MODNAME "\n") < 0)
         return -1;
 
     return 0;
@@ -85,7 +85,7 @@ testKModUnload(const void *args G_GNUC_UNUSED)
         return -1;
     }
 
-    if (checkOutput(&buf, RMMOD " " MODNAME "\n") < 0)
+    if (checkOutput(&buf, "rmmod " MODNAME "\n") < 0)
         return -1;
 
     return 0;