From: Thomas Weißschuh <thomas@t-8ch.de>
Date: Tue, 12 Sep 2023 22:08:59 +0000 (+0200)
Subject: lscpu: remove usage of VLA
X-Git-Tag: v2.40-rc1~246^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b6f635ef8dc264838bb26733349d6df6595124cb;p=thirdparty%2Futil-linux.git

lscpu: remove usage of VLA

Variable-length-arrays are susceptible to security issues, avoid them.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---

diff --git a/sys-utils/lscpu.c b/sys-utils/lscpu.c
index 8333dcbea6..97adaa23ad 100644
--- a/sys-utils/lscpu.c
+++ b/sys-utils/lscpu.c
@@ -855,13 +855,15 @@ print_cpuset(struct lscpu_cxt *cxt,
 	     const char *key, cpu_set_t *set)
 {
 	size_t setbuflen = 7 * cxt->maxcpus;
-	char setbuf[setbuflen], *p;
+	char *setbuf, *p;
 
 	assert(set);
 	assert(key);
 	assert(tb);
 	assert(cxt);
 
+	setbuf = xmalloc(setbuflen);
+
 	if (cxt->hex) {
 		p = cpumask_create(setbuf, setbuflen, set, cxt->setsize);
 		add_summary_s(tb, sec, key, p);
@@ -869,6 +871,8 @@ print_cpuset(struct lscpu_cxt *cxt,
 		p = cpulist_create(setbuf, setbuflen, set, cxt->setsize);
 		add_summary_s(tb, sec, key, p);
 	}
+
+	free(setbuf);
 }
 
 static void