From: Simon Brunel Date: Sun, 6 Jan 2019 14:56:58 +0000 (+0100) Subject: Use `Chart.min.js` in samples (#5958) X-Git-Tag: v2.8.0-rc.1~71 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b7139dbbef9ae978a5e26029bc1620b54c7652b4;p=thirdparty%2FChart.js.git Use `Chart.min.js` in samples (#5958) Samples are supposed to show good practices and in most cases we don't use the time scale but require `Chart.bundle.js`, which is not correct. Instead, we should require the non-bundled version in its minified version (`Chart.min.js`). Paradoxically, time based examples don't use `Chart.bundle.js` but require moment manually side to `Chart.min.js`, which IMO is also the correct way since it allows users to configure and use moment globally (TZ, locales, etc.) and doesn't enforce a specific moment version. Also remove the `data-labelling.html` example because we now have an [official plugin](https://github.com/chartjs/chartjs-plugin-datalabels) that implements this feature and don't want to deal with user custom code anymore. --- diff --git a/samples/advanced/data-labelling.html b/samples/advanced/data-labelling.html deleted file mode 100644 index 52eb07b8f..000000000 --- a/samples/advanced/data-labelling.html +++ /dev/null @@ -1,131 +0,0 @@ - - - - - - Labelling Data Points - - - - - - -
- -
- - - - - diff --git a/samples/advanced/progress-bar.html b/samples/advanced/progress-bar.html index b9c72446e..4736546ba 100644 --- a/samples/advanced/progress-bar.html +++ b/samples/advanced/progress-bar.html @@ -2,7 +2,7 @@ Animation Callbacks - +