From: Darrick J. Wong <djwong@kernel.org>
Date: Mon, 16 Oct 2023 16:21:05 +0000 (-0700)
Subject: xfs: prevent rt growfs when quota is enabled
X-Git-Tag: v6.7-rc1~32^2~8^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b73494fa9a304ab95b59f07845e8d7d36e4d23e0;p=thirdparty%2Flinux.git

xfs: prevent rt growfs when quota is enabled

Quotas aren't (yet) supported with realtime, so we shouldn't allow
userspace to set up a realtime section when quotas are enabled, even if
they attached one via mount options.  IOWS, you shouldn't be able to do:

# mkfs.xfs -f /dev/sda
# mount /dev/sda /mnt -o rtdev=/dev/sdb,usrquota
# xfs_growfs -r /mnt

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index 16534e9873f69..31fd65b3aaa9a 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -954,7 +954,7 @@ xfs_growfs_rt(
 		return -EINVAL;
 
 	/* Unsupported realtime features. */
-	if (xfs_has_rmapbt(mp) || xfs_has_reflink(mp))
+	if (xfs_has_rmapbt(mp) || xfs_has_reflink(mp) || xfs_has_quota(mp))
 		return -EOPNOTSUPP;
 
 	nrblocks = in->newblocks;