From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 8 Jan 2015 22:56:44 +0000 (-0800)
Subject: squidclient: Fix incorrect use of delete on GSSAPI tokens
X-Git-Tag: merge-candidate-3-v1~364
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b745a16e283e327741dc5803e34f6b5810ef54b5;p=thirdparty%2Fsquid.git

squidclient: Fix incorrect use of delete on GSSAPI tokens

  Detected by Coverity Scan. Issue 1261432
---

diff --git a/tools/squidclient/squidclient.cc b/tools/squidclient/squidclient.cc
index d2c49afdaf..245ecec0bc 100644
--- a/tools/squidclient/squidclient.cc
+++ b/tools/squidclient/squidclient.cc
@@ -462,7 +462,7 @@ main(int argc, char *argv[])
                 const char *token = GSSAPI_token(host);
                 snprintf(buf, BUFSIZ, "Authorization: Negotiate %s\r\n", token);
                 strcat(msg, buf);
-                delete token;
+                delete[] token;
             } else
                 std::cerr << "ERROR: server host missing" << std::endl;
         }
@@ -471,7 +471,7 @@ main(int argc, char *argv[])
                 const char *token = GSSAPI_token(Transport::Config.hostname);
                 snprintf(buf, BUFSIZ, "Proxy-Authorization: Negotiate %s\r\n", token);
                 strcat(msg, buf);
-                delete token;
+                delete[] token;
             } else
                 std::cerr << "ERROR: proxy server host missing" << std::endl;
         }