From: Johannes Berg <johannes.berg@intel.com>
Date: Mon, 18 Mar 2024 16:53:17 +0000 (+0200)
Subject: wifi: ieee80211: check for NULL in ieee80211_mle_size_ok()
X-Git-Tag: v6.10-rc1~153^2~363^2~51
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b7793a1a2f370c28b17d9554b58e9dc51afcfcbd;p=thirdparty%2Flinux.git

wifi: ieee80211: check for NULL in ieee80211_mle_size_ok()

For simplicity, we may want to pass a NULL element, and
while we should then pass also a zero length, just be a
bit more careful here.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240318184907.4d983653cb8d.Ic3ea99b60c61ac2f7d38cb9fd202a03c97a05601@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---

diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index 3385a2cc5b099..a99f048404b86 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -5166,7 +5166,7 @@ static inline bool ieee80211_mle_size_ok(const u8 *data, size_t len)
 	bool check_common_len = false;
 	u16 control;
 
-	if (len < fixed)
+	if (!data || len < fixed)
 		return false;
 
 	control = le16_to_cpu(mle->control);