From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 1 Jun 2020 07:34:36 +0000 (+0200)
Subject: transfer: remove k->str NULL check
X-Git-Tag: curl-7_71_0~73
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b77a2528f8d76f7d9878a9e3d1f7744a5becfdd4;p=thirdparty%2Fcurl.git

transfer: remove k->str NULL check

"Null-checking k->str suggests that it may be null, but it has already
been dereferenced on all paths leading to the check" - and it can't
legally be NULL at this point. Remove check.

Detected by Coverity CID 1463884

Closes #5495
---

diff --git a/lib/transfer.c b/lib/transfer.c
index ea337ea1da..319744985b 100644
--- a/lib/transfer.c
+++ b/lib/transfer.c
@@ -688,7 +688,7 @@ static CURLcode readwrite_data(struct Curl_easy *data,
     /* This is not an 'else if' since it may be a rest from the header
        parsing, where the beginning of the buffer is headers and the end
        is non-headers. */
-    if(k->str && !k->header && (nread > 0 || is_empty_data)) {
+    if(!k->header && (nread > 0 || is_empty_data)) {
 
       if(data->set.opt_no_body) {
         /* data arrives although we want none, bail out */