From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 16 Apr 2025 11:09:51 +0000 (+0300)
Subject: rxrpc: rxgk: Set error code in rxgk_yfs_decode_ticket()
X-Git-Tag: v6.16-rc1~132^2~252
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b77ad30c428e6336833d9f28a9907076f8ad9432;p=thirdparty%2Flinux.git

rxrpc: rxgk: Set error code in rxgk_yfs_decode_ticket()

Propagate the error code if key_alloc() fails.  Don't return
success.

Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/Z_-P_1iLDWksH1ik@stanley.mountain
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---

diff --git a/net/rxrpc/rxgk_app.c b/net/rxrpc/rxgk_app.c
index 6206a84395b8b..b94b77a1c3178 100644
--- a/net/rxrpc/rxgk_app.c
+++ b/net/rxrpc/rxgk_app.c
@@ -141,6 +141,7 @@ int rxgk_yfs_decode_ticket(struct rxrpc_connection *conn, struct sk_buff *skb,
 			KEY_ALLOC_NOT_IN_QUOTA, NULL);
 	if (IS_ERR(key)) {
 		_leave(" = -ENOMEM [alloc %ld]", PTR_ERR(key));
+		ret = PTR_ERR(key);
 		goto error;
 	}