From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Fri, 13 Jan 2017 14:41:18 +0000 (+0100)
Subject: qapi: improve device_add schema
X-Git-Tag: v2.9.0-rc0~148^2~176
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b780e9c3f2a29180397ddcd1f3c5e5a5c49353e7;p=thirdparty%2Fqemu.git

qapi: improve device_add schema

'device_add' is still incomplete for now, but we can fix a few
arguments:
- 'bus' is a common argument, regardless of the device
- 'id' is an optional argument

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170113144135.5150-5-marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---

diff --git a/qapi-schema.json b/qapi-schema.json
index 0a3057eb208..863abc418f0 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -2292,7 +2292,7 @@
 #
 # @bus: #optional the device's parent bus (device tree path)
 #
-# @id: the device's ID, must be unique
+# @id: #optional the device's ID, must be unique
 #
 # Additional arguments depend on the type.
 #
@@ -2322,7 +2322,7 @@
 # Since: 0.13
 ##
 { 'command': 'device_add',
-  'data': {'driver': 'str', 'id': 'str'},
+  'data': {'driver': 'str', '*bus': 'str', '*id': 'str'},
   'gen': false } # so we can get the additional arguments
 
 ##