From: Ævar Arnfjörð Bjarmason Date: Wed, 13 Apr 2022 20:01:41 +0000 (+0200) Subject: revisions API users: use release_revisions() in http-push.c X-Git-Tag: v2.37.0-rc0~26^2~15 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b78ce337def2db3a6fceee157f49202e5d1ce46a;p=thirdparty%2Fgit.git revisions API users: use release_revisions() in http-push.c In the case of cmd_main() in http-push.c we need to move the deceleration of the "struct rev-list" into the loop over the "remote_refs" when adding a release_revisions(). We'd previously set up the "revs" for each remote, but would potentially leak memory on each one. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- diff --git a/http-push.c b/http-push.c index f0c044dcf7..01e7c2ac5c 100644 --- a/http-push.c +++ b/http-push.c @@ -1689,7 +1689,6 @@ int cmd_main(int argc, const char **argv) struct refspec rs = REFSPEC_INIT_PUSH; struct remote_lock *ref_lock = NULL; struct remote_lock *info_ref_lock = NULL; - struct rev_info revs; int delete_branch = 0; int force_delete = 0; int objects_to_send; @@ -1825,6 +1824,7 @@ int cmd_main(int argc, const char **argv) new_refs = 0; for (ref = remote_refs; ref; ref = ref->next) { + struct rev_info revs; struct strvec commit_argv = STRVEC_INIT; if (!ref->peer_ref) @@ -1941,6 +1941,7 @@ int cmd_main(int argc, const char **argv) unlock_remote(ref_lock); check_locks(); strvec_clear(&commit_argv); + release_revisions(&revs); } /* Update remote server info if appropriate */