From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Wed, 3 Feb 2021 21:54:35 +0000 (+0100)
Subject: bisect--helper: use `res` instead of return in BISECT_RESET case option
X-Git-Tag: v2.31.0-rc0~45^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b7a6f163d6273896e4f846f63dd711be0174522b;p=thirdparty%2Fgit.git

bisect--helper: use `res` instead of return in BISECT_RESET case option

Use `res` variable to store `bisect_reset()` output in BISECT_RESET
case option to make bisect--helper.c more consistent.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 36b50e3aa8..fd018ddda5 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -1047,7 +1047,8 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 	case BISECT_RESET:
 		if (argc > 1)
 			return error(_("--bisect-reset requires either no argument or a commit"));
-		return !!bisect_reset(argc ? argv[0] : NULL);
+		res = bisect_reset(argc ? argv[0] : NULL);
+		break;
 	case CHECK_AND_SET_TERMS:
 		if (argc != 3)
 			return error(_("--check-and-set-terms requires 3 arguments"));