From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 22 Oct 2024 14:40:06 +0000 (+0000)
Subject: path: Fix a potential memory leak if either path is not absolute
X-Git-Tag: 0.9.30~957
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b7ceb2f80a7a55afb0bb377535cda55cd91083d3;p=pakfire.git

path: Fix a potential memory leak if either path is not absolute

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/path.c b/src/libpakfire/path.c
index 99edf24cd..a0262ebde 100644
--- a/src/libpakfire/path.c
+++ b/src/libpakfire/path.c
@@ -446,8 +446,10 @@ int __pakfire_path_relative(char* buffer, const size_t length, const char* __roo
 		goto ERROR;
 
 	// Both paths must be absolute
-	if (!root->is_absolute || !path->is_absolute)
-		return -EINVAL;
+	if (!root->is_absolute || !path->is_absolute) {
+		r = -EINVAL;
+		goto ERROR;
+	}
 
 	// The result is no longer absolute
 	path->is_absolute = 0;