From: Luyao Huang <lhuang@redhat.com>
Date: Thu, 26 Feb 2015 06:14:20 +0000 (+0800)
Subject: conf: error out on invalid host id
X-Git-Tag: v1.2.9.3~31
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b7d12c5c50c70427b8608bfb01ea80722284595b;p=thirdparty%2Flibvirt.git

conf: error out on invalid host id

https://bugzilla.redhat.com/show_bug.cgi?id=1196503

We already check whether the host id is valid or not, add a jump
to forbid invalid host id.

Signed-off-by: Luyao Huang <lhuang@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
(cherry picked from commit 719cd2182bf06196b26204a8cf88d28001b1d79b)
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 892bd8a2c3..6812f15488 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -725,6 +725,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName,
             virReportError(VIR_ERR_XML_ERROR,
                            _("Invalid character '%c' in id '%s' of network '%s'"),
                            *cp, id, networkName);
+            goto cleanup;
         }
     }