From: Osier Yang <jyang@redhat.com>
Date: Wed, 2 May 2012 15:05:59 +0000 (+0800)
Subject: Coverity: Fix the forward_null error in Python binding codes
X-Git-Tag: v0.9.12-rc2~38
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b80f4db9931ceea4bec1d178322058df77ece7a4;p=thirdparty%2Flibvirt.git

Coverity: Fix the forward_null error in Python binding codes

Related coverity log:

Error: FORWARD_NULL:
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:355:
assign_zero: Assigning: "params" = 0.
/builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:458:
var_deref_model: Passing null variable "params" to function
"getPyVirTypedParameter", which dereferences it. (The dereference is assumed on
the basis of the 'nonnull' parameter attribute.)
---

diff --git a/python/libvirt-override.c b/python/libvirt-override.c
index 56f96babc5..130e702d84 100644
--- a/python/libvirt-override.c
+++ b/python/libvirt-override.c
@@ -71,7 +71,7 @@ static char *py_str(PyObject *obj)
 /* Helper function to convert a virTypedParameter output array into a
  * Python dictionary for return to the user.  Return NULL on failure,
  * after raising a python exception.  */
-static PyObject * ATTRIBUTE_NONNULL(1)
+static PyObject *
 getPyVirTypedParameter(const virTypedParameterPtr params, int nparams)
 {
     PyObject *key, *val, *info;