From: Mark Wielaard Date: Mon, 9 May 2022 15:32:24 +0000 (+0200) Subject: debuginfod: Check result of curl_easy_getinfo in debuginfod_write_callback X-Git-Tag: elfutils-0.188~74 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b814a7e45199d1c0812f3dffc23284ef66988f1e;p=thirdparty%2Felfutils.git debuginfod: Check result of curl_easy_getinfo in debuginfod_write_callback This was the only place in debuginfod-client.c where we didn't check the result of curl_easy_getinfo. Just check it to make things consistent. Signed-off-by: Mark Wielaard --- diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog index 1c5cd4e21..8f69409b3 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,3 +1,8 @@ +2022-05-09 Mark Wielaard + + * debuginfod-client.c (debuginfod_write_callback): Check result + of curl_easy_getinfo. + 2022-05-05 Mark Wielaard * debuginfod.cxx (main): Define use_epoll. Set to MHD_USE_EPOLL diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c index 521972e4a..882a809a0 100644 --- a/debuginfod/debuginfod-client.c +++ b/debuginfod/debuginfod-client.c @@ -213,8 +213,9 @@ debuginfod_write_callback (char *ptr, size_t size, size_t nmemb, void *data) *d->target_handle = d->handle; /* update the client object */ const char *url = NULL; - (void) curl_easy_getinfo (d->handle, CURLINFO_EFFECTIVE_URL, &url); - if (url) + CURLcode curl_res = curl_easy_getinfo (d->handle, + CURLINFO_EFFECTIVE_URL, &url); + if (curl_res == CURLE_OK && url) { free (d->client->url); d->client->url = strdup(url); /* ok if fails */