From: Charles Han <hanchunchao@inspur.com>
Date: Fri, 27 Dec 2024 09:20:46 +0000 (+0800)
Subject: Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()
X-Git-Tag: v6.14-rc1~162^2~19^2~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b88655bc6593c6a7fdc1248b212d17e581c4334e;p=thirdparty%2Fkernel%2Flinux.git

Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()

devm_kstrdup() can return a NULL pointer on failure,but this
returned value in btbcm_get_board_name() is not checked.
Add NULL check in btbcm_get_board_name(), to handle kernel NULL
pointer dereference error.

Fixes: f9183eaad915 ("Bluetooth: btbcm: Use devm_kstrdup()")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index a1153ada74d20..0a60660fc8ce8 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -553,6 +553,9 @@ static const char *btbcm_get_board_name(struct device *dev)
 
 	/* get rid of any '/' in the compatible string */
 	board_type = devm_kstrdup(dev, tmp, GFP_KERNEL);
+	if (!board_type)
+		return NULL;
+
 	strreplace(board_type, '/', '-');
 
 	return board_type;