From: GeoSot Date: Thu, 9 Sep 2021 23:13:58 +0000 (+0300) Subject: Carousel: remove always true `visibilityState` check X-Git-Tag: v5.2.0-beta1~338 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b8ee68cfa0f3516dc55aec5da6d7e43e2705f402;p=thirdparty%2Fbootstrap.git Carousel: remove always true `visibilityState` check According to https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState `visibilityState` is always a string, so the check was always true --- diff --git a/js/src/carousel.js b/js/src/carousel.js index 336bcd261a..e91ba376c1 100644 --- a/js/src/carousel.js +++ b/js/src/carousel.js @@ -126,6 +126,7 @@ class Carousel extends BaseComponent { } nextWhenVisible() { + // FIXME TODO use `document.visibilityState` // Don't call next when the page isn't visible // or the carousel or its parent isn't visible if (!document.hidden && isVisible(this._element)) { @@ -164,10 +165,7 @@ class Carousel extends BaseComponent { if (this._config.interval && !this._isPaused) { this._updateInterval() - this._interval = setInterval( - (document.visibilityState ? this.nextWhenVisible : this.next).bind(this), - this._config.interval - ) + this._interval = setInterval(() => this.nextWhenVisible(), this._config.interval) } }