From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Tue, 12 Aug 2025 10:13:49 +0000 (+0100)
Subject: soc: ti: k3-navss-ringacc: NULL check before dereference
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b90927bd0d81096239ff4a48a71c3d9e87ef7209;p=thirdparty%2Fu-boot.git

soc: ti: k3-navss-ringacc: NULL check before dereference

Move the first dereference of ring to after the NULL check has occurred.
This will prevent any possible dereference of NULL.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---

diff --git a/drivers/soc/ti/k3-navss-ringacc.c b/drivers/soc/ti/k3-navss-ringacc.c
index 14114a65830..ac29158d489 100644
--- a/drivers/soc/ti/k3-navss-ringacc.c
+++ b/drivers/soc/ti/k3-navss-ringacc.c
@@ -632,12 +632,14 @@ err_free_ops:
 int k3_nav_ringacc_ring_cfg(struct k3_nav_ring *ring,
 			    struct k3_nav_ring_cfg *cfg)
 {
-	struct k3_nav_ringacc *ringacc = ring->parent;
+	struct k3_nav_ringacc *ringacc;
 	int ret = 0;
 
 	if (!ring || !cfg)
 		return -EINVAL;
 
+	ringacc = ring->parent;
+
 	if (ringacc->dual_ring)
 		return k3_dmaring_ring_cfg(ring, cfg);