From: Wei Yongjun Date: Wed, 6 May 2020 13:56:25 +0000 (+0000) Subject: USB: ohci-sm501: fix error return code in ohci_hcd_sm501_drv_probe() X-Git-Tag: v5.8-rc1~108^2~44 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b919e077cccfbb77beb98809568b2fb0b4d113ec;p=thirdparty%2Fkernel%2Flinux.git USB: ohci-sm501: fix error return code in ohci_hcd_sm501_drv_probe() Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 7d9e6f5aebe8 ("usb: host: ohci-sm501: init genalloc for local memory") Signed-off-by: Wei Yongjun Acked-by: Alan Stern Link: https://lore.kernel.org/r/20200506135625.106910-1-weiyongjun1@huawei.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c index c158cda9e4b9b..cff9652403270 100644 --- a/drivers/usb/host/ohci-sm501.c +++ b/drivers/usb/host/ohci-sm501.c @@ -157,9 +157,10 @@ static int ohci_hcd_sm501_drv_probe(struct platform_device *pdev) * the call to usb_hcd_setup_local_mem() below does just that. */ - if (usb_hcd_setup_local_mem(hcd, mem->start, - mem->start - mem->parent->start, - resource_size(mem)) < 0) + retval = usb_hcd_setup_local_mem(hcd, mem->start, + mem->start - mem->parent->start, + resource_size(mem)); + if (retval < 0) goto err5; retval = usb_add_hcd(hcd, irq, IRQF_SHARED); if (retval)