From: Mark Cave-Ayland Date: Sun, 24 Feb 2013 20:46:11 +0000 (+0000) Subject: ide/macio: Fix macio DMA initialisation. X-Git-Tag: v1.4.1~31 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b91aee581090f9066a09111a220cf5c300fa56cc;p=thirdparty%2Fqemu.git ide/macio: Fix macio DMA initialisation. Commit 07a7484e5d713f1eb7c1c37b18a8ab0d56d88875 accidentally introduced a bug in the initialisation of the second macio DMA device which could cause some DMA operations to segfault QEMU. CC: Andreas Färber Signed-off-by: Mark Cave-Ayland Acked-by: Andreas Färber Signed-off-by: Stefan Hajnoczi (cherry picked from commit 02d583c7232d65920634f7553700eb348f84e472) Signed-off-by: Michael Roth --- diff --git a/hw/macio.c b/hw/macio.c index 74bdcd10397..0c6a6b8e7ab 100644 --- a/hw/macio.c +++ b/hw/macio.c @@ -188,7 +188,7 @@ static int macio_newworld_initfn(PCIDevice *d) sysbus_dev = SYS_BUS_DEVICE(&ns->ide[1]); sysbus_connect_irq(sysbus_dev, 0, ns->irqs[3]); sysbus_connect_irq(sysbus_dev, 1, ns->irqs[4]); - macio_ide_register_dma(&ns->ide[0], s->dbdma, 0x1a); + macio_ide_register_dma(&ns->ide[1], s->dbdma, 0x1a); ret = qdev_init(DEVICE(&ns->ide[1])); if (ret < 0) { return ret;