From: kbuild test robot <fengguang.wu@intel.com>
Date: Thu, 6 Apr 2017 13:55:19 +0000 (-0700)
Subject: apparmor: fix boolreturn.cocci warnings
X-Git-Tag: v4.12-rc1~123^2~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b9c42ac76ea13ab6d07681ff3079b3a242333764;p=thirdparty%2Fkernel%2Flinux.git

apparmor: fix boolreturn.cocci warnings

security/apparmor/lib.c:132:9-10: WARNING: return of 0/1 in function 'aa_policy_init' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
---

diff --git a/security/apparmor/lib.c b/security/apparmor/lib.c
index 66475bda6f722..32cafc12593ef 100644
--- a/security/apparmor/lib.c
+++ b/security/apparmor/lib.c
@@ -180,13 +180,13 @@ bool aa_policy_init(struct aa_policy *policy, const char *prefix,
 	} else
 		policy->hname = kstrdup(name, gfp);
 	if (!policy->hname)
-		return 0;
+		return false;
 	/* base.name is a substring of fqname */
 	policy->name = basename(policy->hname);
 	INIT_LIST_HEAD(&policy->list);
 	INIT_LIST_HEAD(&policy->profiles);
 
-	return 1;
+	return true;
 }
 
 /**