From: Amos Jeffries <squid3@treenet.co.nz>
Date: Fri, 20 Jun 2008 03:31:58 +0000 (+1200)
Subject: Bug 2384: Assertion failed on ESI page.
X-Git-Tag: SQUID_3_1_0_1~49^2~197
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b9fde3d83f68dcab6b541c6bc0b823cf817920be;p=thirdparty%2Fsquid.git

Bug 2384: Assertion failed on ESI page.

ESI was deleting its reference to child HTTP requests instead of unlocking
them. Even if they were in use elsewhere.

TODO: A better approach may be to cancel the dependent child request
entirely and close its resources down in a chain-reaction.
---

diff --git a/src/ESI.cc b/src/ESI.cc
index 3aa898e9b0..9854db32be 100644
--- a/src/ESI.cc
+++ b/src/ESI.cc
@@ -1425,12 +1425,9 @@ ESIContext::ParserState::popAll()
 void
 ESIContext::freeResources ()
 {
-    debugs(86, 5, "ESIContext::freeResources: Freeing for this=" << this);
+    debugs(86, 5, HERE << "Freeing for this=" << this);
 
-    if (rep) {
-        delete rep;
-        rep = NULL;
-    }
+    HTTPMSGUNLOCK(rep);
 
     finishChildren ();