From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 15 Jan 2024 15:28:04 +0000 (+0100)
Subject: tool_operate: stop setting the file comment on Amiga
X-Git-Tag: curl-8_6_0~82
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ba01cac39b47906802be22cd2230555f8f7cac79;p=thirdparty%2Fcurl.git

tool_operate: stop setting the file comment on Amiga

- the URL is capped at 80 cols, which ruins it if longer
- it does not strip off URL credentials
- it is done unconditonally, not on --xattr
- we don't have Amiga in the CI which makes fixing it blindly fragile

Someone who builds and tests on Amiga can add it back correctly in a
future if there is a desire.

Reported-by: Harry Sintonen
Closes #12709
---

diff --git a/src/tool_operate.c b/src/tool_operate.c
index 3fe5b51165..1ffd6730ec 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -343,22 +343,6 @@ static CURLcode pre_transfer(struct GlobalConfig *global,
   return result;
 }
 
-#ifdef __AMIGA__
-static void AmigaSetComment(struct per_transfer *per,
-                            CURLcode result)
-{
-  struct OutStruct *outs = &per->outs;
-  if(!result && outs->s_isreg && outs->filename) {
-    /* Set the url (up to 80 chars) as comment for the file */
-    if(strlen(per->this_url) > 78)
-      per->this_url[79] = '\0';
-    SetComment(outs->filename, per->this_url);
-  }
-}
-#else
-#define AmigaSetComment(x,y) Curl_nop_stmt
-#endif
-
 /* When doing serial transfers, we use a single fixed error area */
 static char global_errorbuffer[CURL_ERROR_SIZE];
 
@@ -658,8 +642,6 @@ noretry:
     }
   }
 
-  AmigaSetComment(per, result);
-
   /* File time can only be set _after_ the file has been closed */
   if(!result && config->remote_time && outs->s_isreg && outs->filename) {
     /* Ask libcurl if we got a remote file time */