From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 6 Nov 2023 12:24:43 +0000 (+0100)
Subject: tool_operate: do not mix memory models
X-Git-Tag: curl-8_5_0~131
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ba281e5c7251d92615dcfdac5e6da1da51bb77c6;p=thirdparty%2Fcurl.git

tool_operate: do not mix memory models

Make sure 'inputpath' only points to memory allocated by libcurl so that
curl_free works correctly.

Pointed out by Coverity

Follow-up to 859e88f6533f9e1f890

Closes #12280
---

diff --git a/src/tool_operate.c b/src/tool_operate.c
index 649bb91f42..88be9aaad7 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -907,11 +907,8 @@ static CURLcode ipfs_url_rewrite(CURLU *uh, const char *protocol, char **url,
   curl_url_get(gatewaysurl, CURLUPART_PATH, &gatewaypath, CURLU_URLDECODE);
 
   /* get the path from user input */
-  if(curl_url_get(uh, CURLUPART_PATH, &inputpath, CURLU_URLDECODE)) {
-    inputpath = strdup("");
-    if(!inputpath)
-      goto clean;
-  }
+  curl_url_get(uh, CURLUPART_PATH, &inputpath, CURLU_URLDECODE);
+  /* inputpath might be NULL or a valid pointer now */
 
   /* set gateway parts in input url */
   if(curl_url_set(uh, CURLUPART_SCHEME, gatewayscheme, CURLU_URLENCODE)) {
@@ -927,16 +924,14 @@ static CURLcode ipfs_url_rewrite(CURLU *uh, const char *protocol, char **url,
   }
 
   /* if the input path is just a slash, clear it */
-  if(inputpath && *inputpath && strlen(inputpath) == 1) {
-    if(*inputpath == '/') {
-      *inputpath = '\0';
-    }
-  }
+  if(inputpath && (inputpath[0] == '/') && !inputpath[1])
+    *inputpath = '\0';
 
   /* ensure the gateway path ends with a trailing slash */
   ensure_trailing(&gatewaypath, '/');
 
-  pathbuffer = aprintf("%s%s/%s%s", gatewaypath, protocol, cid, inputpath);
+  pathbuffer = aprintf("%s%s/%s%s", gatewaypath, protocol, cid,
+                       inputpath ? inputpath : "");
   if(!pathbuffer) {
     goto clean;
   }